Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NVIDIA/container-canary
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.4.0
Choose a base ref
...
head repository: NVIDIA/container-canary
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: refs/heads/main
Choose a head ref
  • 4 commits
  • 10 files changed
  • 1 contributor

Commits on Jul 31, 2024

  1. fix formatting in CONTRIBUTING docs (#66) 

    Signed-off-by: James Lamb <jlamb@nvidia.com>
    @jameslamb
    jameslamb authored Jul 31, 2024
    Configuration menu
    Copy the full SHA
    d2fa403 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. upgrade golangci-lint, run pre-commit in CI, add more pre-commit hooks ( 

    #67)

* upgrade golangci-lint, run pre-commit in CI, add more pre-commit hooks

Signed-off-by: James Lamb <jlamb@nvidia.com>

* remove setup-python

Signed-off-by: James Lamb <jlamb@nvidia.com>

---------

Signed-off-by: James Lamb <jlamb@nvidia.com>
    @jameslamb
    jameslamb authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    2e70e2b View commit details
    Browse the repository at this point in the history

  2. avoid unnecessary build context in 'make testprep' (#68) 

    Signed-off-by: James Lamb <jlamb@nvidia.com>
    @jameslamb
    jameslamb authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ed10893 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Make container startup timeout configurable (#65) 

    * make container startup timeout configurable

Signed-off-by: James Lamb <jlamb@nvidia.com>

* address linter warnings

Signed-off-by: James Lamb <jlamb@nvidia.com>

* simplify

Signed-off-by: James Lamb <jlamb@nvidia.com>

* use a different, less segfault-y path to pass configuration

Signed-off-by: James Lamb <jlamb@nvidia.com>

* remove startupTimeout from the Container class

Signed-off-by: James Lamb <jlamb@nvidia.com>

* more simplifications

Signed-off-by: James Lamb <jlamb@nvidia.com>

* add tests

Signed-off-by: James Lamb <jlamb@nvidia.com>

* revert tests

Signed-off-by: James Lamb <jlamb@nvidia.com>

* revert one more test thing

Signed-off-by: James Lamb <jlamb@nvidia.com>

---------

Signed-off-by: James Lamb <jlamb@nvidia.com>
    @jameslamb
    jameslamb authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    42e3d11 View commit details
    Browse the repository at this point in the history
Loading