Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize nocomp mode with large trees #995

Merged
merged 18 commits into from
Mar 23, 2023
Merged

Initialize nocomp mode with large trees #995

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ddc8a42
New initialisation mode - using initd to mean initial dbh.
Feb 22, 2023
3d56c69
Fix bug in net_c_uptake by leaf layer and pft history variable
Feb 22, 2023
0a36a4c
Tidy up initialising large sizes
Feb 24, 2023
2395e6f
Incrase nlevleaf to prevent errors from vai param updates
Feb 28, 2023
4974368
Remove non-dbh init changes
Mar 2, 2023
3121230
Revert "Fix bug in net_c_uptake by leaf layer and pft history variable"
Mar 2, 2023
db3107a
Remove history variable not part of this PR
Mar 2, 2023
1371185
Merge branch 'main' into JFN-nocomp-init-large-sizes
Mar 2, 2023
3816fe1
Tidying
Mar 2, 2023
188a4fc
Add errors if user tries to use dbh initialisation outside of nocomp …
Mar 2, 2023
c30ec70
Fix typo
Mar 2, 2023
4192818
Fix canopy spread to 0 for large tree initialization
Mar 14, 2023
8700189
Add param checks to ensure initd isn't zero. Remove old write stateme…
Mar 14, 2023
95d9db3
Add more comments describing dbh-initialization and the dual function…
Mar 20, 2023
85bf550
Merge branch 'main' into JFN-nocomp-init-large-sizes
glemieux Mar 22, 2023
df7dd3f
Add xml patch parameter file
glemieux Mar 22, 2023
e50b27b
move call to bleaf so it is avoided by sp mode
Mar 23, 2023
7ebb166
Merge remote-tracking branch 'jfneedham_repo/JFN-nocomp-init-large-si…
Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move call to bleaf so it is avoided by sp mode
  • Loading branch information
Jessica F Needham committed Mar 23, 2023
commit e50b27bc6e10f1b4d235cebde7e9aa687f8cc9a0
15 changes: 11 additions & 4 deletions main/EDInitMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,11 @@ subroutine init_cohorts( site_in, patch_in, bc_in)
! Calculate the plant diameter from height
call h2d_allom(temp_cohort%hite,pft,temp_cohort%dbh)

! Calculate the leaf biomass from allometry
! (calculates a maximum first, then applies canopy trim)
call bleaf(temp_cohort%dbh,pft,temp_cohort%crowndamage, &
temp_cohort%canopy_trim,c_leaf)

endif ! sp mode

else ! interpret as initial diameter and calculate density
Expand All @@ -865,16 +870,18 @@ subroutine init_cohorts( site_in, patch_in, bc_in)

! calculate initial density required to close canopy
temp_cohort%n = patch_in%area / temp_cohort%c_area

! Calculate the leaf biomass from allometry
! (calculates a maximum first, then applies canopy trim)
call bleaf(temp_cohort%dbh,pft,temp_cohort%crowndamage, &
temp_cohort%canopy_trim,c_leaf)

else
write(fates_log(),*) 'Negative fates_recruit_init_density can only be used in no comp mode'
call endrun(msg=errMsg(sourcefile, __LINE__))
endif
endif

! Calculate the leaf biomass from allometry
! (calculates a maximum first, then applies canopy trim)
call bleaf(temp_cohort%dbh,pft,temp_cohort%crowndamage, &
temp_cohort%canopy_trim,c_leaf)

! Calculate total above-ground biomass from allometry
call bagw_allom(temp_cohort%dbh,pft,temp_cohort%crowndamage,c_agw)
Expand Down