NO-JIRA removing duplicated method

MysteryZ · Jan 11, 2023 · 2713bc0 · 2713bc0
1 parent edf6bb1
commit 2713bc0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 16 deletions.
diff --git a/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ComponentUpdater.java b/server/sonar-webserver-webapi/src/main/java/org/sonar/server/component/ComponentUpdater.java
@@ -97,19 +97,6 @@ public ComponentDto create(DbSession dbSession, NewComponent newComponent, @Null
     return componentDto;
   }
 
-  /**
-   * - Create component
-   * - Apply default permission template
-   * - Add component to favorite if the component has the 'Project Creators' permission
-   * - Index component in es indexes
-   */
-  public ComponentDto createApplicationOrPortfolio(DbSession dbSession, NewComponent newComponent, @Nullable String userUuid,
-    @Nullable String userLogin, @Nullable String mainBranchName) {
-    ComponentDto componentDto = createWithoutCommit(dbSession, newComponent, userUuid, userLogin, mainBranchName, c -> {});
-    commitAndIndex(dbSession, componentDto);
-    return componentDto;
-  }
-
   public void commitAndIndex(DbSession dbSession, ComponentDto componentDto) {
     projectIndexers.commitAndIndexComponents(dbSession, singletonList(componentDto), Cause.PROJECT_CREATION);
   }

diff --git a/...sonar-webserver-webapi/src/test/java/org/sonar/server/component/ComponentUpdaterTest.java b/...sonar-webserver-webapi/src/test/java/org/sonar/server/component/ComponentUpdaterTest.java
@@ -337,10 +337,10 @@ public void create_shouldFail_whenCreatingProjectWithExistingKeyButDifferentCase
   }
 
   @Test
-  public void createApplicationOrPortfolio_createsComponentWithMasterBranchName() {
+  public void create_createsComponentWithMasterBranchName() {
     String componentNameAndKey = "createApplicationOrPortfolio";
-    ComponentDto app = underTest.createApplicationOrPortfolio(db.getSession(),
-      NewComponent.newComponentBuilder().setName(componentNameAndKey).setKey(componentNameAndKey).setQualifier("APP").build(), null, null, null);
+    ComponentDto app = underTest.create(db.getSession(), NewComponent.newComponentBuilder().setName(componentNameAndKey)
+      .setKey(componentNameAndKey).setQualifier("APP").build(), null, null, null);
 
     Optional<BranchDto> branch = db.getDbClient().branchDao().selectByUuid(db.getSession(), app.branchUuid());
     assertThat(branch).isPresent();