rpc benchmark: json rpc benchmark #20912
Open
+358
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
jsonrpc-bench
branch
from
96a1b86 to
5fa2843
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
gegaowp
force-pushed
the
jsonrpc-bench
branch
from
5fa2843 to
f97ea40
Compare
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
reviewed
Jan 22, 2025
gegaowp
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
lxfind
approved these changes
Jan 23, 2025
| stream.try_for_each_spawned(concurrency, |fut| fut), | ||
| ) | ||
| .await | ||
| .unwrap_or(Ok(()))?; |
There was a problem hiding this comment.
Is .unwrap_or(Ok(()) basically unwrap()?
There was a problem hiding this comment.
not really, per the timeout doc
/// If the future completes before the duration has elapsed, then the completed
/// value is returned. Otherwise, an error is returned and the future is
/// canceled.
so .unwrap_or(Ok(()) intends to catch the early-termination-error and exit gracefully instead of panic right away -- meanwhile propagating the errors from try_for_each_spawned if anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
will collect more logs from production and stress test with logs pulled from loki API
Test plan
local run and verify on report
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.