Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #20746

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Fix typos #20746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix typos 
Signed-off-by: oliveredget <188809800+oliveredget@users.noreply.github.com>
  • Loading branch information
@oliveredget
oliveredget committed Dec 31, 2024
commit 25644ae6b59faab32602ea180aa77f9adec65df4
4 changes: 2 additions & 2 deletions consensus/core/src/core_thread.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ impl CoreThread {
let exists = *self.rx_subscriber_exists.borrow();
self.core.set_subscriber_exists(exists);
if !should_propose_before && self.core.should_propose() {
// If core cannnot propose before but can propose now, try to produce a new block to ensure liveness,
// If core cannot propose before but can propose now, try to produce a new block to ensure liveness,
// because block proposal could have been skipped.
self.core.new_block(Round::MAX, true)?;
}
Expand All @@ -159,7 +159,7 @@ impl CoreThread {
state.accepted_quorum_rounds
);
if !should_propose_before && self.core.should_propose() {
// If core cannnot propose before but can propose now, try to produce a new block to ensure liveness,
// If core cannot propose before but can propose now, try to produce a new block to ensure liveness,
// because block proposal could have been skipped.
self.core.new_block(Round::MAX, true)?;
}
Expand Down
2 changes: 1 addition & 1 deletion consensus/core/src/leader_scoring.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ pub(crate) struct ScoringSubdag {
// TODO: Include skipped leaders as well
pub(crate) leaders: HashSet<BlockRef>,
// A map of votes to the stake of strongly linked blocks that include that vote
// Note: Inlcuding stake aggregator so that we can quickly check if it exceeds
// Note: Including stake aggregator so that we can quickly check if it exceeds
// quourum threshold and only include those scores for certain scoring strategies.
pub(crate) votes: BTreeMap<BlockRef, StakeAggregator<QuorumThreshold>>,
}
Expand Down
2 changes: 1 addition & 1 deletion consensus/core/src/linearizer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ impl Linearizer {
.filter(|ancestor| {
// We skip the block if we already committed it or we reached a
// round that we already committed.
// TODO: for Fast Path we need to ammend the recursion rule here and allow us to commit blocks all the way up to the `gc_round`.
// TODO: for Fast Path we need to amend the recursion rule here and allow us to commit blocks all the way up to the `gc_round`.
// Some additional work will be needed to make sure that we keep the uncommitted blocks up to the `gc_round` across commits.
!committed.contains(ancestor)
&& last_committed_rounds[ancestor.author] < ancestor.round
Expand Down
2 changes: 1 addition & 1 deletion crates/sui/src/clever_error_rendering.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
//! error message using the clever error rendering logic.
//!
//! The logic in this file is largely a stop-gap to provide Clever Error rendering in the CLI while
//! it still uses the JSON-RPC API. The new GraphQL API already renderd Clever Errors on the server
//! it still uses the JSON-RPC API. The new GraphQL API already rendered Clever Errors on the server
//! side in a much more robust and efficient way.
//!
//! Once the CLI is updated to use the GraphQL API, this file can be removed, and the GraphQL-based
Expand Down
2 changes: 1 addition & 1 deletion crates/sui/src/client_ptb/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ impl<'a, I: Iterator<Item = &'a str>> ProgramParser<'a, I> {
Ok(sp.wrap(addr))
}

/// Parse a numeric addres literal (must be prefixed by an `@` symbol).
/// Parse a numeric address literal (must be prefixed by an `@` symbol).
fn parse_address_literal(&mut self) -> PTBResult<Spanned<NumericalAddress>> {
let sp!(sp, _) = self.expect(Token::At).map_err(|e| {
err!(e.span => help: {
Expand Down
Loading