Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Only use referenced dependencies in the linkage table #20509

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
+113 −46
Open

[CLI] Only use referenced dependencies in the linkage table #20509

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cb9c4db
Only use referenced dependencies in the linkage table
stefan-mysten Dec 4, 2024
faa38c1
Fixes
stefan-mysten Dec 5, 2024
89355a2
Improve code by removing clone on list and instead making the variabl…
stefan-mysten Dec 6, 2024
21aefe4
Try to fix tests?
stefan-mysten Dec 6, 2024
d39ff41
Test
stefan-mysten Dec 6, 2024
4ca0536
WIP
stefan-mysten Dec 6, 2024
c1aac20
Fixes
stefan-mysten Dec 13, 2024
f6f53d1
Fix test
stefan-mysten Dec 13, 2024
4de4e55
Fixes
stefan-mysten Dec 14, 2024
1de9d7a
Fix test
stefan-mysten Dec 19, 2024
b69890c
Fix
stefan-mysten Dec 19, 2024
7122a7f
Try to fix test by fixing the chain-id in the Move.lock to the one of…
stefan-mysten Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes
  • Loading branch information
@stefan-mysten
stefan-mysten committed Jan 17, 2025
commit 4de4e55ad6f86fc8e552b9469db1d6d8c2970ccc
2 changes: 2 additions & 0 deletions crates/sui-move-build/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,8 @@ pub fn build_from_resolution_graph(
(address != AccountAddress::ZERO).then_some(address)
})
.collect();
println!("Orig deps: {:?}", dependency_ids);
println!("All compiled units ids: {:?}", deps);
dependency_ids.published.retain(|_, id| deps.contains(id));

Ok(CompiledPackage {
Expand Down
1 change: 1 addition & 0 deletions external-crates/move/crates/move-package/src/resolution/resolution_graph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,7 @@ impl Package {
continue;
}
// There is no lock file, but perhaps there is a `published-at` in the manifest.
// but what if published-at is the upgraded package id?
else if let Some(published_at) = self
.source_package
.package
Expand Down