move-package: collect overrides from collect_graphs (refactor) #15801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
rvantonder
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Looks good @kklas! Could you rebase? I think we updated something in main that triggers the cargo-deny-action that's failing 🙏
Moved `collect_overrides` functionality to a more natural place. This is used for resolve_version hook implementation later so that the manifest doesn't have to be parsed again.
kklas
force-pushed
the
refactor-collect-overrides
branch
from
f695d73 to
6df80de
Compare
|
rebase pushed |
|
thanks @kklas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved
collect_overridesfunctionality to a more natural place. This is used for resolve_version hook implementation later so that the manifest doesn't have to be parsed again.This is part of the work to enable compiling against on-chain
dependencies #14178.
cc @rvantonder @amnn
Test Plan
It's a pure refactor. Ran unit tests.
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes