Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] upgrade to react-query v5 #14346

Merged
merged 24 commits into from
Oct 24, 2023
Merged

[frontend] upgrade to react-query v5 #14346

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
806dcc5
TanStack Query v5
Jordan-Mysten Oct 19, 2023
7f0f3e7
fix
williamrobertson13 Oct 19, 2023
92b69da
fix
williamrobertson13 Oct 19, 2023
4042ac8
work
williamrobertson13 Oct 19, 2023
2f8a5ab
fix
williamrobertson13 Oct 19, 2023
e3e0b72
work
williamrobertson13 Oct 19, 2023
997521c
fix
williamrobertson13 Oct 19, 2023
b651867
ix
williamrobertson13 Oct 19, 2023
6bb0c0a
fix
williamrobertson13 Oct 19, 2023
caaa8a0
work
williamrobertson13 Oct 19, 2023
138c4f2
fix
williamrobertson13 Oct 19, 2023
9ecf272
work
williamrobertson13 Oct 23, 2023
df6d37f
support select
williamrobertson13 Oct 23, 2023
db96274
Merge remote-tracking branch 'origin/main' into wrobertson/v5_query
williamrobertson13 Oct 24, 2023
8c64d63
fix tests
williamrobertson13 Oct 24, 2023
eec1b26
work
williamrobertson13 Oct 24, 2023
14e36a8
work
williamrobertson13 Oct 24, 2023
16845a5
work
williamrobertson13 Oct 24, 2023
2400981
fix
williamrobertson13 Oct 24, 2023
0f5874a
fix
williamrobertson13 Oct 24, 2023
96d45e5
fix
williamrobertson13 Oct 24, 2023
2fb28de
fix
williamrobertson13 Oct 24, 2023
5c9162e
fix
williamrobertson13 Oct 24, 2023
575d011
fix
williamrobertson13 Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@williamrobertson13
williamrobertson13 committed Oct 23, 2023
commit 138c4f28ce23c4896a6b32e8c85a99d84cba49c9
10 changes: 5 additions & 5 deletions sdk/dapp-kit/src/hooks/useSuiClientQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ export type SuiRpcMethods = {
: never;
};

export type UseSuiClientQueryOptions<
T extends keyof SuiRpcMethods,
TData = SuiRpcMethods[T]['result'],
> = PartialBy<
export type UseSuiClientQueryOptions<T extends keyof SuiRpcMethods, TData> = PartialBy<
Omit<UseQueryOptions<SuiRpcMethods[T]['result'], Error, TData, unknown[]>, 'queryFn'>,
'queryKey'
>;

export function useSuiClientQuery<T extends keyof SuiRpcMethods, TData>(
export function useSuiClientQuery<
Copy link
Contributor Author

@williamrobertson13 williamrobertson13 Oct 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @hayes-mysten! would you mind sanity-checking the typing for TData I added here?

Basically, we want to allow folks to specify a custom return type for the data field to allow transformations via select. By default though, we'll just use SuiRpcMethods[T]['result']. Example:

// data should be typed as '123'
const {data} = useSuiClientQuery('blahrpc', { select: (data) => '123' as const });

// data should be typed as the return of blahrpc result
const {data} = useSuiClientQuery('blahrpc');

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

T extends keyof SuiRpcMethods,
TData = SuiRpcMethods[T]['result'],
>(
...args: undefined extends SuiRpcMethods[T]['params']
? [method: T, params?: SuiRpcMethods[T]['params'], options?: UseSuiClientQueryOptions<T, TData>]
: [method: T, params: SuiRpcMethods[T]['params'], options?: UseSuiClientQueryOptions<T, TData>]
Expand Down