Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Issue-2750 - Remove log pollution #2840

Merged
merged 3 commits into from
Mar 3, 2021
Merged

Issue-2750 - Remove log pollution #2840

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f39e71a
Issue-2750 - Remove log pollution
DiegoAsterio Feb 15, 2021
130d517
Issue-2750 - Remove log pollution
DiegoAsterio Feb 15, 2021
a00fe86
Merge branch 'bugfix/issue-2750' of https://github.com/DiegoAsterio/m…
DiegoAsterio Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mycroft/skills/skill_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ def __init__(self, bus, watchdog=None):
self.num_install_retries = 0
self.settings_downloader = SkillSettingsDownloader(self.bus)

self.empty_skill_dirs = set() # Save a record of empty skill dirs.

# Statuses
self._alive_status = False # True after priority skills has loaded
self._loaded_status = False # True after all skills has loaded
Expand Down Expand Up @@ -314,8 +316,13 @@ def _get_skill_directories(self):
# check if folder is a skill (must have __init__.py)
if SKILL_MAIN_MODULE in os.listdir(skill_dir):
skill_directories.append(skill_dir.rstrip('/'))
if skill_dir in self.empty_skill_dirs:
self.empty_skill_dirs.discard(skill_dir)
else:
LOG.debug('Found skills directory with no skill: ' + skill_dir)
if skill_dir not in self.empty_skill_dirs:
self.empty_skill_dirs.add(skill_dir)
LOG.debug('Found skills directory with no skill: ' +
skill_dir)

return skill_directories

Expand Down