GMMS-7597 [Android] Add Clear Conversation button to top bar menu #132
Conversation
| @@ -69,6 +69,7 @@ class MainActivity : AppCompatActivity(), ChatEventListener { | |||
| private val hasActiveChats get() = chatController?.hasOpenChats() == true | |||
| private var chatController: ChatController? = null | |||
| private var endMenu: MenuItem? = null | |||
| private var clearConversationMenu: MenuItem? = null | |||
There was a problem hiding this comment.
I know the rest of the items don't have it, but shouldn't all of them have the word item in the end? For example: clearConversationMenuItem
There was a problem hiding this comment.
I don't know if it makes any difference. If you really want, I can add it.
| @@ -107,7 +108,6 @@ class MainActivity : AppCompatActivity(), ChatEventListener { | |||
| } | |||
|
|
|||
| viewModel.authCode.observe(this@MainActivity) { | |||
| logoutMenu?.isVisible = viewModel.isAuthenticated | |||
There was a problem hiding this comment.
@SzaszaGenesys , The visibility update has been removed, don’t we need to add updateMenuVisibility() call here?
There was a problem hiding this comment.
Same here as on the internal-app. It turned out that it was unnecessary.
| @@ -227,16 +229,20 @@ class MainActivity : AppCompatActivity(), ChatEventListener { | |||
| return false | |||
| } | |||
|
|
|||
| private fun showClearConversationDialog() { | |||
| AlertDialog.Builder(this) | |||
There was a problem hiding this comment.
Is there design / confirmation from Product that the alert dialog is not part of SDK?
There was a problem hiding this comment.
Is there design / confirmation from Product that the alert dialog is not part of SDK?
We talked about it with Product, it is documented in the charter page, it shouldn't be part of the SDK. There is no design from UX, it should be a native dialog.
No description provided.