Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide an option or command to generate configuration file from modernizer CLI tool #1642

Closed
peterblazejewicz opened this issue Sep 12, 2015 · 4 comments
Closed

Provide an option or command to generate configuration file from modernizer CLI tool #1642

peterblazejewicz opened this issue Sep 12, 2015 · 4 comments

Comments

@peterblazejewicz
Copy link
Contributor

I think the statements on the documentation page for v.3 are somehow exaggerated and contradictory:

Now you are ready to get your start making your custom build! You can download the configuration file from the build menu (under "Command Line Config").

https://modernizr.com/docs/#using-modernizr-with-javascript

When I'm ready (have installed via NPM) I need to go to website. What if I went just online but have tool installed? Or just starting user of CLI and hit the wall:
How to use Modernizr v3?

How about:

mondernizr init

or similar sounding command option? It could just copy lib/config-all.js as default config to the same directory where modernizr.js file is created.

The Modernizr is now self-contained tool without dependency on Bower, so it somehow should be able to bootstrap itself for use (bower init, npm init)

Thanks!
@patrickkettner
Copy link
Member

Hey @peterblazejewicz!

I agree that the docs could be improved with an example on what a config looks like. Would you be interested in PRing a change to add it here?

We actually are trying hard to avoid situations in which people might ship the entire set of detects, because it is massive and wholly unnecessary for most sites. An init command that creates en empty set of detects isn't a bad idea though! A PR would be very welcomed.

If you need any guidance on where to start I would be more than happy to help!

@patrickkettner
Copy link
Member

Ping @peterblazejewicz

@peterblazejewicz
Copy link
Contributor Author

@patrickkettner
I've been playing with update tool during this weekend and have better idea how tool is now envisioned to work (I wondered how will I use it at work).
I think I could do PR in future to create a blanket JSON config file. For this we don't need this issue. So I'll close it now.
The content of blanked JSON could be discussed in PR, as it seems you have not rejected idea. I hope I can contribute to docs in some way.
Thanks!

@patrickkettner
Copy link
Member

Thanks a lot!
It's totally OK go leave the issue open in case you get too busy to finish
the PR, someone else can find it and carry the torch.

Either way - looking forward to your contribution!

On Tue, Sep 15, 2015, 12:10 PM Peter Blazejewicz notifications@github.com
wrote:

@patrickkettner https://github.com/patrickkettner
I've been playing with update tool during this weekend and have better
idea how tool is now envisioned to work (I wondered how will I use it at
work).
I think I could do PR in future to create a blanket JSON config file. For
this we don't need this issue. So I'll close it now.
The content of blanked JSON could be discussed in PR, as it seems you have
not rejected idea. I hope I can contribute to docs in some way.
Thanks!

—
Reply to this email directly or view it on GitHub
#1642 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peterblazejewicz @patrickkettner