Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoder updated twice for curl loss #28

Open
xy9485 opened this issue Mar 7, 2023 · 2 comments
Open

encoder updated twice for curl loss #28

xy9485 opened this issue Mar 7, 2023 · 2 comments

Comments

@xy9485
Copy link

xy9485 commented Mar 7, 2023

I'm looking into the code and find that in def update_cpc() both self.encoder_optimizer.step() and self.cpc_optimizer.step() are called. However the parameters of critic.encoder are carried by both optimizer. Isn't it true that, in def update_cpc(), critic.encoder is updated twice using the same gradient?
@Penelope-zhang
Copy link

@xy9485 do you know why critic.encoder is updated twice in def update_cpc()?

@LYK-love
Copy link

Yeah that's true. I don't know the reason of doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xy9485 @LYK-love @Penelope-zhang