Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Momentum update is never used in the code #26

Open
datonefaridze opened this issue Oct 25, 2022 · 1 comment
Open

Momentum update is never used in the code #26

datonefaridze opened this issue Oct 25, 2022 · 1 comment

Comments

@datonefaridze
Copy link

Hi, I was going thought the code and couldn't find where momentum encoder was being updated, I think it is initialized only once at the beginning and then isn't trained at all
@Chengyui
Copy link

Chengyui commented Jan 7, 2023

Cause the CURL encoder is a part of the critic and critic_target. In SAC, critic and critic_target need to be soft_update. So there is no need to do it again in CURL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@datonefaridze @Chengyui