Remove incompatible visit_unsupported_body

The subclasses had a different signature, and returned a list instead of a string.
MiguelMarcelino · Jul 7, 2021 · 4ed1af0 · 4ed1af0
1 parent da403fe
commit 4ed1af0
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 46 deletions.
diff --git a/pydart/transpiler.py b/pydart/transpiler.py
@@ -443,12 +443,6 @@ def visit_Tuple(self, node):
             return elts
         return "({0})".format(elts)
 
-    def visit_unsupported_body(self, name, body):
-        buf = ["let {0} = {{ //unsupported".format(name)]
-        buf += [self.visit(n) for n in body]
-        buf.append("};")
-        return buf
-
     def visit_Raise(self, node):
         if node.exc is not None:
             return "throw new {};".format(self.visit(node.exc))

diff --git a/pygo/transpiler.py b/pygo/transpiler.py
@@ -563,21 +563,15 @@ def visit_Tuple(self, node):
             return elts
         return "{0}".format(elts)
 
-    def visit_unsupported_body(self, name, body):
-        buf = ["let {0} = {{ //unsupported".format(name)]
-        buf += [self.visit(n) for n in body]
-        buf.append("};")
-        return buf
-
     def visit_Try(self, node, finallybody=None):
-        buf = self.visit_unsupported_body("try_dummy", node.body)
+        buf = self.visit_unsupported_body(node, "try_dummy", node.body)
 
         for handler in node.handlers:
             buf += self.visit(handler)
         # buf.append("\n".join(excepts));
 
         if finallybody:
-            buf += self.visit_unsupported_body("finally_dummy", finallybody)
+            buf += self.visit_unsupported_body(node, "finally_dummy", finallybody)
 
         return "\n".join(buf)
 
@@ -586,7 +580,7 @@ def visit_ExceptHandler(self, node):
         if node.type:
             exception_type = self.visit(node.type)
         name = "except!({0})".format(exception_type)
-        body = self.visit_unsupported_body(name, node.body)
+        body = self.visit_unsupported_body(node, name, node.body)
         return body
 
     def visit_Assert(self, node):

diff --git a/pyjl/transpiler.py b/pyjl/transpiler.py
@@ -459,21 +459,15 @@ def visit_Tuple(self, node):
             return elts
         return "({0})".format(elts)
 
-    def visit_unsupported_body(self, name, body):
-        buf = ["let {0} = {{ //unsupported".format(name)]
-        buf += [self.visit(n) for n in body]
-        buf.append("}")
-        return buf
-
     def visit_Try(self, node, finallybody=None):
-        buf = self.visit_unsupported_body("try_dummy", node.body)
+        buf = self.visit_unsupported_body(node, "try_dummy", node.body)
 
         for handler in node.handlers:
             buf += self.visit(handler)
         # buf.append("\n".join(excepts));
 
         if finallybody:
-            buf += self.visit_unsupported_body("finally_dummy", finallybody)
+            buf += self.visit_unsupported_body(node, "finally_dummy", finallybody)
 
         return "\n".join(buf)
 
@@ -482,7 +476,7 @@ def visit_ExceptHandler(self, node):
         if node.type:
             exception_type = self.visit(node.type)
         name = "except!({0})".format(exception_type)
-        body = self.visit_unsupported_body(name, node.body)
+        body = self.visit_unsupported_body(node, name, node.body)
         return body
 
     def visit_Assert(self, node):

diff --git a/pykt/transpiler.py b/pykt/transpiler.py
@@ -442,21 +442,15 @@ def visit_Tuple(self, node):
             return elts
         return "({0})".format(elts)
 
-    def visit_unsupported_body(self, name, body):
-        buf = ["let {0} = {{ //unsupported".format(name)]
-        buf += [self.visit(n) for n in body]
-        buf.append("};")
-        return buf
-
     def visit_Try(self, node, finallybody=None):
-        buf = self.visit_unsupported_body("try_dummy", node.body)
+        buf = self.visit_unsupported_body(node, "try_dummy", node.body)
 
         for handler in node.handlers:
             buf += self.visit(handler)
         # buf.append("\n".join(excepts));
 
         if finallybody:
-            buf += self.visit_unsupported_body("finally_dummy", finallybody)
+            buf += self.visit_unsupported_body(node, "finally_dummy", finallybody)
 
         return "\n".join(buf)
 
@@ -465,7 +459,7 @@ def visit_ExceptHandler(self, node):
         if node.type:
             exception_type = self.visit(node.type)
         name = "except!({0})".format(exception_type)
-        body = self.visit_unsupported_body(name, node.body)
+        body = self.visit_unsupported_body(node, name, node.body)
         return body
 
     def visit_Assert(self, node):

diff --git a/pynim/transpiler.py b/pynim/transpiler.py
@@ -435,21 +435,15 @@ def visit_Tuple(self, node):
             return elts
         return "({0})".format(elts)
 
-    def visit_unsupported_body(self, name, body):
-        buf = ["let {0} = {{ //unsupported".format(name)]
-        buf += [self.visit(n) for n in body]
-        buf.append("};")
-        return buf
-
     def visit_Try(self, node, finallybody=None):
-        buf = self.visit_unsupported_body("try_dummy", node.body)
+        buf = self.visit_unsupported_body(node, "try_dummy", node.body)
 
         for handler in node.handlers:
             buf += self.visit(handler)
         # buf.append("\n".join(excepts));
 
         if finallybody:
-            buf += self.visit_unsupported_body("finally_dummy", finallybody)
+            buf += self.visit_unsupported_body(node, "finally_dummy", finallybody)
 
         return "\n".join(buf)
 
@@ -458,7 +452,7 @@ def visit_ExceptHandler(self, node):
         if node.type:
             exception_type = self.visit(node.type)
         name = "except!({0})".format(exception_type)
-        body = self.visit_unsupported_body(name, node.body)
+        body = self.visit_unsupported_body(node, name, node.body)
         return body
 
     def visit_Assert(self, node):

diff --git a/pyrs/transpiler.py b/pyrs/transpiler.py
@@ -721,14 +721,14 @@ def visit_Tuple(self, node):
             return elts
         return "({0})".format(elts)
 
-    def visit_unsupported_body(self, name, body):
+    def grrvisit_unsupported_body(self, node, name, body):
         buf = ["let {0} = {{ //unsupported".format(name)]
         buf += [self.visit(n) for n in body]
         buf.append("};")
-        return buf
+        return "\n".join(buf)
 
     def visit_Try(self, node, finallybody=None):
-        # buf = self.visit_unsupported_body("try_dummy", node.body)
+        # buf = self.visit_unsupported_body(node, "try_dummy", node.body)
         buf = ["if true {"]
         buf += [self.visit(n) for n in node.body]
 
@@ -747,7 +747,7 @@ def visit_ExceptHandler(self, node):
         if node.type:
             exception_type = self.visit(node.type)
         name = "// except!({0})".format(exception_type)
-        body = self.visit_unsupported_body(name, node.body)
+        body = self.visit_unsupported_body(node, name, node.body)
         body = [self.comment(b) for b in body]
         return body