-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script migration #444
base: main
Are you sure you want to change the base?
Script migration #444
Conversation
In progress, do not merge. |
Learn Build status updates of commit edffd4b: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
microsoftgraph/graph-powershell-1.0/Microsoft.Graph.Applications/Get-MgApplication.md
microsoftgraph/docs-conceptual/migrate_scripts.md
microsoftgraph/docs-conceptual/toc.yml
microsoftgraph/graph-powershell-1.0/Microsoft.Graph.Applications/index.yml
This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
…h-docs-powershell into script_migration
Learn Build status updates of commit 706c79c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit feb7d22: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 55ebb47: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for drafting this and for creating the AI model. It's going to simplify the migration work by a great deal.
I left a minor suggestion on how to reduce the length of the article but otherwise, it looks great.
I'll set up some time next week to set up the project on my machine and test the Python script using this guidance. I'll let you know if I run into any issues.
# General exception | ||
print(f"Error updating script from {file}. Exception occurred: {e}") | ||
``` | ||
## Prompts used with the GPT-4 model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prompts content is very good and important for the audience. I'm not sure if we can have it hosted somewhere else, like maybe on the readme for the Python app, then we can point the readers to it from this article. I feel like the article is quite long as it is and cutting off this section will shorten it considerably.
Let me know what you think.
Learn Build status updates of commit f9d9a9e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 6c78e24: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 2a2607f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
…h-docs-powershell into script_migration
Learn Build status updates of commit 052f89e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @rwike77.
How to article on using Azure OpenAI to migrate scripts to Microsoft Graph PowerShell