Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling indexing #31

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

StorytellerCZ
Copy link
Member

Per #17 this PR allows to set Meteor.settings.collection2.dontRunIndexing to true which will then disable the indexing functionality.

To discuss here is that maybe we should enable this only for development.

@harryadel
Copy link
Member

harryadel commented Jan 16, 2024

I don't really see the point?? Why not remove the indexes you created? A big kill switch isn't that big of a deal really. Especially given how simple it's to use this packages index: 1 How hard it's for you to search the code and remove those statements?? 👎

@StorytellerCZ
Copy link
Member Author

Simple answer: packages
If you have a package that depends on this package and sets indexes via collection2, then unless you have this option or manually edit the target package you have to do things manually in MongoDB and every time your server updates.

@harryadel
Copy link
Member

like what packages?

@StorytellerCZ
Copy link
Member Author

StorytellerCZ commented Jan 16, 2024

Socialize packages, freedombase:legal-management, etc.

In general feature packages that add collections.

@harryadel
Copy link
Member

ok, fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow disabling of indexing with an environment variable or Meteor.setting
2 participants