Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snaps): allow usage of Text in Value props #29624

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Jan 10, 2025

Description

This PR allows the usage of the Text component in the Snap UI Value component props.

Open in GitHub Codespaces

Related issues

progresses: MetaMask/snaps#2984

Manual testing steps

<Box>
  <Row label="Amount">
    <Value
      value={<Text color="success">1.555 ETH</Text>}
      extra={<Text color="error">2.44 $</Text>}
    />
  </Row>
</Box>

Screenshots/Recordings

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jan 10, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [7888efa]
Page Load Metrics (1539 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint25916951471289139
domContentLoaded1409168615138742
load1417174415398742
domInteractive19235585526
backgroundConnect86527199
firstReactRender1595452813
getState415732
initialActions01000
loadScripts1013128311238340
setupStore66712157
uiStartup159324551799208100
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 444 Bytes (0.01%)
  • common: -4.81 KiB (-0.06%)

@FrederikBolding FrederikBolding changed the base branch from main to fb/snaps-bump-v82 January 14, 2025 11:57
@FrederikBolding FrederikBolding marked this pull request as ready for review January 14, 2025 15:46
@FrederikBolding FrederikBolding requested a review from a team as a code owner January 14, 2025 15:46
@FrederikBolding FrederikBolding merged commit a87c1b4 into fb/snaps-bump-v82 Jan 14, 2025
87 checks passed
@FrederikBolding FrederikBolding deleted the gr/allow-text-in-value branch January 14, 2025 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants