Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move getMetaMaskAccounts to remove circular dependency #29590

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

refactor: move getMetaMaskAccounts to remove circular dependency #29590

wants to merge 6 commits into from
+783 −683

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Jan 8, 2025 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [f9a8907]
Page Load Metrics (1570 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31218121506288138
domContentLoaded1407176715438239
load1465181215708340
domInteractive207735189
backgroundConnect76226189
firstReactRender1599402713
getState47312157
initialActions01000
loadScripts1038135211527837
setupStore65614168
uiStartup16742116182712761
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 146 Bytes (0.00%)
  • common: 8.77 KiB (0.11%)

@davidmurdoch
more fixes (and more fixes to clean up :-( )
6e5f789
@davidmurdoch
missed some
96c489c
@davidmurdoch
this might work well...
5d8c328 
a `<subject>-core.js` with `<category>-<subcategory>.js` files that point back to it, but core never points to a subcategory file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidmurdoch davidmurdoch

Labels
team-extension-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidmurdoch @metamaskbot @gauthierpetetin