test: [POM] Migrate bitcoin send e2e tests to POM #29515

chloeYue · 2025-01-08T16:31:48Z

Description

Migrate send transaction e2e tests with bitcoin account to POM
Create related Bitcoin transaction page class and methods.

Related issues

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-01-08T16:32:00Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…tamask-extension into chloe-btc-send-tests

metamaskbot · 2025-01-08T21:14:49Z

Builds ready [4354a85]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1710 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1558	2015	1705	113	54
		domContentLoaded	1527	2001	1679	116	56
		load	1566	2021	1710	116	56
		domInteractive	25	136	47	30	15
		backgroundConnect	12	66	32	19	9
		firstReactRender	16	95	39	26	12
		getState	5	63	12	13	6
		initialActions	0	1	0	0	0
		loadScripts	1091	1422	1246	95	46
		setupStore	6	66	17	19	9
		uiStartup	1744	2340	1946	158	76

metamaskbot · 2025-01-09T10:44:28Z

Builds ready [998f740]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1545 ± 36 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1468	1764	1553	75	36
		domContentLoaded	1451	1696	1524	64	31
		load	1460	1764	1545	76	36
		domInteractive	23	63	34	13	6
		backgroundConnect	9	69	23	18	9
		firstReactRender	15	92	31	24	12
		getState	4	53	14	14	7
		initialActions	0	1	0	0	0
		loadScripts	1070	1291	1136	55	27
		setupStore	6	85	16	24	11
		uiStartup	1629	2469	1831	214	103

chloeYue · 2025-01-10T17:00:01Z

test/e2e/flask/btc/common-btc.ts

@@ -18,12 +18,6 @@ import HeaderNavbar from '../../page-objects/pages/header-navbar';

 const QUICKNODE_URL_REGEX = /^https:\/\/.*\.btc.*\.quiknode\.pro(\/|$)/u;

-export enum SendFlowPlaceHolders {


Intended change, variables have been put in page class

migrate tests

c343149

chloeYue added e2e-test End to end test for the MetaMask extension team-qa QA team labels Jan 8, 2025

chloeYue self-assigned this Jan 8, 2025

chloeYue requested a review from a team as a code owner January 8, 2025 16:31

metamaskbot added the team-extension-platform label Jan 8, 2025

chloeYue marked this pull request as draft January 8, 2025 16:32

chloeYue and others added 4 commits January 8, 2025 17:32

Merge branch 'main' into chloe-btc-send-tests

1fadd11

fix

fc793a4

Merge branch 'chloe-btc-send-tests' of https://github.com/MetaMask/me…

b24103e

…tamask-extension into chloe-btc-send-tests

fix

4354a85

chloeYue added 2 commits January 9, 2025 11:08

revert changes in yml

88d2bd3

revert yml changes

998f740

chloeYue changed the title ~~test: migrate tests~~ test: [POM] Create base classes and methods for bitcoin e2e tests Jan 10, 2025

chloeYue changed the title ~~test: [POM] Create base classes and methods for bitcoin e2e tests~~ test: [POM] Migrate bitcoin send e2e tests to POM Jan 10, 2025

chloeYue commented Jan 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: [POM] Migrate bitcoin send e2e tests to POM #29515

test: [POM] Migrate bitcoin send e2e tests to POM #29515

chloeYue commented Jan 8, 2025 •

edited

Loading

github-actions bot commented Jan 8, 2025

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 9, 2025

chloeYue Jan 10, 2025 •

edited

Loading

		@@ -18,12 +18,6 @@ import HeaderNavbar from '../../page-objects/pages/header-navbar';

		const QUICKNODE_URL_REGEX = /^https:\/\/.\.btc.\.quiknode\.pro(\/\|$)/u;

		export enum SendFlowPlaceHolders {

test: [POM] Migrate bitcoin send e2e tests to POM #29515

Are you sure you want to change the base?

test: [POM] Migrate bitcoin send e2e tests to POM #29515

Conversation

chloeYue commented Jan 8, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 8, 2025

metamaskbot commented Jan 8, 2025

metamaskbot commented Jan 9, 2025

chloeYue Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

chloeYue commented Jan 8, 2025 •

edited

Loading

chloeYue Jan 10, 2025 •

edited

Loading