calling math.Ceil on a converted integer is pointless

MaxHalford · Oct 15, 2019 · 2e17279 · 2e17279
1 parent 965738d
commit 2e17279
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/speciation.go b/speciation.go
@@ -3,7 +3,6 @@ package eaopt
 import (
 	"errors"
 	"fmt"
-	"math"
 	"math/rand"
 )
 
@@ -120,7 +119,7 @@ func (spec SpecFitnessInterval) Apply(indis Individuals, rng *rand.Rand) ([]Indi
 	var (
 		species = make([]Individuals, spec.K)
 		n       = len(indis)
-		m       = minInt(int(math.Ceil(float64(n/int(spec.K)))), n)
+		m       = minInt(int(float64(n/int(spec.K))), n)
 	)
 	for i := range species {
 		var a, b = i * m, minInt((i+1)*m, n)

diff --git a/speciation_test.go b/speciation_test.go
@@ -3,7 +3,6 @@ package eaopt
 import (
 	"errors"
 	"fmt"
-	"math"
 	"testing"
 )
 
@@ -110,7 +109,7 @@ func TestSpecFitnessIntervalApply(t *testing.T) {
 	for _, nbi := range nIndividuals {
 		for _, nbs := range nSpecies {
 			var (
-				m          = minInt(int(math.Ceil(float64(nbi/nbs))), int(nbi))
+				m          = minInt(int(float64(nbi/nbs)), int(nbi))
 				indis      = newIndividuals(nbi, NewVector, rng)
 				spec       = SpecFitnessInterval{K: nbs}
 				species, _ = spec.Apply(indis, rng)