Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in RasterizingTileLayer MapInfo #2843

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

pauldendulk
Copy link
Member

When tapping the line in the RasterizingTileLayer sample no info was shown and now there is.

@pauldendulk
Copy link
Member Author

pauldendulk commented Jan 5, 2025

@inforithmics My changes may have introduced the bug, it is fixed now but I am still not quite sure how it should work. What happened in the RasterizingTileLayer is that the result from the regular MapInfo was ignored, only the async MapInfo was used. It worked like this before the MapInfo changes. Perhaps in an earlier stage this result contained both sync and async results. Because of the changes to the MapInfo these are now completely separate things.

One thing not fully clear to me was if or why we needed the async request in the RasterizingTileLayer. Now looking at how it behaves I see the values actually come from the sync MapInfo. So, I think we should remove the async MapInfo request. If we find a case where it is needed we could think about it again.

@pauldendulk
Copy link
Member Author

@inforithmics I am going to merge this to include it in the next release. In an another PR I intent to remove the ILayerFeatureInfo from the RasterizingTileLayer because I don't see samples that depend on it.

@pauldendulk pauldendulk merged commit 659b446 into main Jan 6, 2025
5 checks passed
@pauldendulk pauldendulk deleted the feature/fix-bug-in-rasterizinglayer-mapinfo branch January 6, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant