Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to manim.cli module #3988

Merged
merged 12 commits into from
Nov 4, 2024
Merged

Add type hints to manim.cli module #3988

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1d3f4c7
Add type hints to cli
chopan050 Oct 28, 2024
81bb66f
Import click.Parameter instead of non existing cloup.Parameter
chopan050 Oct 28, 2024
94eb489
Merge branch 'main' into cli-typehints
chopan050 Oct 28, 2024
0d21fbf
Stop ignoring manim.cli errors in mypy.ini
chopan050 Oct 28, 2024
135ea70
Merge branch 'cli-typehints' of https://github.com/chopan050/manim in…
chopan050 Oct 28, 2024
af42bd5
Fix mypy errors
chopan050 Oct 29, 2024
47044b1
Remove unused TypeVar C
chopan050 Oct 29, 2024
8f0af8d
click.Command.command -> cloup.Group.command
chopan050 Oct 29, 2024
3c21e93
Address Jason's requested changes
chopan050 Oct 30, 2024
756aa2b
Merge branch 'main' into cli-typehints
chopan050 Oct 30, 2024
9407877
exit() -> sys.exit()
chopan050 Nov 4, 2024
7e902de
Merge branch 'main' into cli-typehints
chopan050 Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
click.Command.command -> cloup.Group.command
  • Loading branch information
@chopan050
chopan050 committed Oct 29, 2024
commit 8f0af8d4db631a46417d99722e2ad12358b8807b
4 changes: 2 additions & 2 deletions manim/cli/default_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,9 +167,9 @@ def command(self, *args: Any, **kwargs: Any) -> Callable[[Callable], Command]:
Parameters
----------
*args
Positional arguments to pass to :meth:`click.Command.command`.
Positional arguments to pass to :meth:`click.Group.command`.
**kwargs
Keyword arguments to pass to :meth:`click.Command.command`.
Keyword arguments to pass to :meth:`click.Group.command`.

Returns
-------
Expand Down
Loading