kubernetes: handle new pod restartPolicy format #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @abonas @Fryguy @blomquisg |
simon3z
force-pushed
the
pod-restartpolicy
branch
from
982baef to
d0d0a3b
Compare
| @@ -67,11 +67,16 @@ def parse_service(service) | |||
| def parse_pod(pod) | |||
| # pod in kubernetes is container group in manageiq | |||
| new_result = parse_base_item(pod) | |||
| # TODO: https://github.com/GoogleCloudPlatform/kubernetes/issues/3607 | |||
There was a problem hiding this comment.
This comment doesn't make it clear what needs "TODO". It just points to an issue that is already closed. Can you update the comment to explain that the TODO is to remove this version specific code once old versions are assured to no longer be used?
|
Are there specs for this? On that note are there any kube VCR specs? cc @abonas |
This patch adds the support of the new restartPolicy format: kubernetes/kubernetes#3607 Until we're sure that everyone updated their kubernetes instance (probably until v1.0 is officially released) it's better to handle both. Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
simon3z
force-pushed
the
pod-restartpolicy
branch
from
d0d0a3b to
4ba239f
Compare
|
Checked commit simon3z@4ba239f with rubocop 0.27.1 |
Fryguy
added a commit
that referenced
this pull request
Mar 26, 2015
kubernetes: handle new pod restartPolicy format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the support of the new restartPolicy format:
kubernetes/kubernetes#3607
Until we're sure that everyone updated their kubernetes instance (probably until v1.0 is officially released) it's better to handle both.