Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy_url generating invalid URLs for k8s 1.10 #322

Closed
lambertjosh opened this issue May 10, 2018 · 2 comments
Closed

proxy_url generating invalid URLs for k8s 1.10 #322

lambertjosh opened this issue May 10, 2018 · 2 comments
Labels
bug

Comments

@lambertjosh
Copy link
Contributor

It looks like kubeclient proxy_url may be generating an incorrect or out of date proxy URL format.

Right now for services, it outputs as documented in the README this format: /api/v1/proxy/namespaces/ns/services/srvname:srvportname

However the Kubernetes documentation specifically states the following format: /api/v1/namespaces/ns/services/srvname:srvportname/proxy

We've found that the current string format, works well in GKE and other places. However recently on minikube, it has started to fail. The officially documented format however still works.

Perhaps the gem should switch over to generating the officially documented version?
@lambertjosh
Copy link
Contributor Author

I was peeking at the code, and it seems like not only does services support the new scheme it may no longer support the old scheme?

https://github.com/abonas/kubeclient/blob/master/lib/kubeclient/common.rb#L402

@lambertjosh
Copy link
Contributor Author

lambertjosh commented May 10, 2018 •
edited
Loading

Looks like it was removed in 1.10 here: kubernetes/kubernetes#59884

Stated this API path was deprecated in 1.2.

@lambertjosh lambertjosh mentioned this issue May 10, 2018
Merged
@lambertjosh lambertjosh changed the title proxy_url seems to be generated incorrect URLs proxy_url generating invalid URLs for k8s 1.10 May 10, 2018
@cben cben added the bug label May 24, 2018
@cben cben closed this as completed in #323 Jun 27, 2018
@cben cben mentioned this issue Jul 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cben @lambertjosh