Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-188): Remove old UI and API #253

Merged
merged 28 commits into from
Sep 19, 2024

Conversation

fras2560
Copy link
Member

Checklist

  • I have added the appropriate label to this PR ("bug", "feature")
  • I have assigned myself to this PR
  • I have performed a self-review of my code
  • I have tested my changes to the best of my abilities (not just unit tests, but integration/end-to-end tests as well)

Issues closed

Closes #188

Related issues

Description

Remove old API documentation and APIs
Remove the admin ui
Move score submission functions to new api
Add some queries - Move some previous functions from advanced to queries
Import from new queries functions

Screenshots

@fras2560 fras2560 added infrastructure Developer infrastructure python Pull requests that update Python code labels Sep 17, 2024
@fras2560 fras2560 self-assigned this Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 86.47541% with 33 lines in your changes missing coverage. Please review.

Project coverage is 94.23%. Comparing base (19e0dd5) to head (98253e6).
Report is 1 commits behind head on development.

Files with missing lines Patch % Lines
api/restx/game.py 68.05% 23 Missing ⚠️
api/restx/player.py 85.36% 6 Missing ⚠️
api/cached_items.py 85.71% 1 Missing ⚠️
api/importers/league.py 50.00% 1 Missing ⚠️
api/restx/schedule.py 95.00% 1 Missing ⚠️
api/restx/team.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #253      +/-   ##
===============================================
- Coverage        95.11%   94.23%   -0.88%     
===============================================
  Files              137      118      -19     
  Lines            11383    10224    -1159     
===============================================
- Hits             10827     9635    -1192     
- Misses             556      589      +33     
Flag Coverage Δ
unittests 94.23% <86.47%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fras2560 fras2560 merged commit ac822b5 into development Sep 19, 2024
3 of 5 checks passed
@fras2560 fras2560 deleted the feature/issue-188-remove-old-ui branch November 5, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Developer infrastructure python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant