-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issue-188): Remove old UI and API #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move re-used functions to restx game
Convert some of the tests to pytests
Move some previous functions from advanced to queries
Team stats and schedules replace with new rest APIs Have standings use the new rest route
They are no longer needed for anything
They should not be needed at this point
fras2560
added
infrastructure
Developer infrastructure
python
Pull requests that update Python code
labels
Sep 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #253 +/- ##
===============================================
- Coverage 95.11% 94.23% -0.88%
===============================================
Files 137 118 -19
Lines 11383 10224 -1159
===============================================
- Hits 10827 9635 -1192
- Misses 556 589 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No need for circular dependencies or multiple add models call Additionally organise the namespace alphabetically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issues closed
Closes #188
Related issues
Description
Remove old API documentation and APIs
Remove the admin ui
Move score submission functions to new api
Add some queries - Move some previous functions from advanced to queries
Import from new queries functions
Screenshots