Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arch: Find a Pattern for Entering/Exiting Draft Mode for Replacements #225

Open
MajeedKazemi opened this issue Jul 15, 2021 · 0 comments
Open

Arch: Find a Pattern for Entering/Exiting Draft Mode for Replacements #225

MajeedKazemi opened this issue Jul 15, 2021 · 0 comments
Labels
architecture The architecture of a feature refactoring Refactor code

Comments

@MajeedKazemi
Copy link
Owner

Replacements are difficult to handle for the draft mode:

  • we first need to check if the prev expression could actually be part of the new wrapping expression
  • we should also check if the new wrapping expression could replace the prev expression's root

This could be a pattern to be used for many insertions.
@MajeedKazemi MajeedKazemi added refactoring Refactor code redesign feature Redesign a feature architecture The architecture of a feature and removed redesign feature Redesign a feature labels Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture The architecture of a feature refactoring Refactor code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MajeedKazemi