Catch PDHexception on object initialization (oshi#1070)

MR-Os1 · Dec 30, 2019 · 98965e4 · 98965e4
1 parent 34562f1
commit 98965e4
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/oshi-core/src/main/java/oshi/util/platform/windows/PerfCounterWildcardQuery.java b/oshi-core/src/main/java/oshi/util/platform/windows/PerfCounterWildcardQuery.java
@@ -141,7 +141,13 @@ private static String localize(String perfObject) {
         try {
             localized = PdhUtil.PdhLookupPerfNameByIndex(null, PdhUtil.PdhLookupPerfIndexByEnglishName(perfObject));
         } catch (Win32Exception e) {
-            LOG.error("Unable to locate English counter names in registry Perflib 009. Assuming English counters.");
+            LOG.error(
+                    "Unable to locate English counter names in registry Perflib 009. Assuming English counters. Error {}. {}",
+                    String.format("0x%x", e.getHR().intValue()),
+                    "See https://support.microsoft.com/en-us/help/300956/how-to-manually-rebuild-performance-counter-library-values");
+        } catch (PdhException e) {
+            LOG.error("Unable to localize {} performance counter.  Error {}.", perfObject,
+                    String.format("0x%x", e.getErrorCode()));
         }
         if (localized == null || localized.length() == 0) {
             return perfObject;