Skip to content

Commit

Permalink
chore(dependencies): pin matplotlib<=3.9.4 for now (#238)
Browse files Browse the repository at this point in the history
Some of the example scripts have begun to break with matplotlib 3.10. Most of the failures are due to the removal of the collections attribute from ContourSet and related API changes. We will need to rewrite some things to work around this. For reference see the corresponding change from a while ago in flopy.

Two failures however seem to be internal to matplotlib, with pillow being used incorrectly:

Traceback (most recent call last):
    File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/matplotlib/animation.py", line 224, in saving
      yield self
    File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/matplotlib/animation.py", line 1126, in save
      writer.grab_frame(**savefig_kwargs)
    File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/matplotlib/animation.py", line 499, in grab_frame
      self._frame.append(im)
  AttributeError: 'PillowWriter' object has no attribute '_frame'. Did you mean: '_frames'?

While we address the former and wait for a resolution for the latter, we can just pin mpl.
  • Loading branch information
wpbonelli authored Dec 17, 2024
1 parent 0623eb7 commit b2f22aa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion etc/requirements.pip.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ pytest-xdist
appdirs
requests
numpy
matplotlib
matplotlib<=3.9.4
bmipy
affine
scipy
Expand Down

0 comments on commit b2f22aa

Please sign in to comment.