Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOA-028][Enhancement] Log the messages for entire the Business (Service). #49

Closed
LyQuocCuong opened this issue Jul 22, 2023 · 1 comment · Fixed by #52
Closed

[SOA-028][Enhancement] Log the messages for entire the Business (Service). #49

LyQuocCuong opened this issue Jul 22, 2023 · 1 comment · Fixed by #52
Assignees
@LyQuocCuong
Labels
[Level] Easy Level of Issues [Type] Enhancement Type of Issues
Milestone
[Stage01] Foundat...

Comments

@LyQuocCuong
Copy link
Owner

=====BEFORE=====

1) Describe the current situation

  • Currently, the Business module is missing logging messages.

2) What are the ideas for it?

  • Using ILogService to log messages.

3) Is it mandatory/optional? What if I don't enhance?

  • It's mandatory. I will apply it for entire the project.

=====AFTER=====

1) Describe the solutions

2) Pros and Cons of this solution

3) Are there any NEW (technical, code,...) ?

4) Is it challenging and difficult to do? Why?

5) Any other notes?
@LyQuocCuong LyQuocCuong added [Type] Enhancement Type of Issues [Level] Easy Level of Issues labels Jul 22, 2023
@LyQuocCuong LyQuocCuong added this to the [S01] Foundation (Basic) milestone Jul 22, 2023
@LyQuocCuong LyQuocCuong self-assigned this Jul 22, 2023
@github-project-automation github-project-automation bot moved this to ⚫ Not Started in eShopOnlineApi Jul 22, 2023
@LyQuocCuong LyQuocCuong moved this from ⚫ Not Started to 🔖 Ready in eShopOnlineApi Jul 22, 2023
@LyQuocCuong LyQuocCuong moved this from 🔖 Ready to 🏗 In progress in eShopOnlineApi Jul 22, 2023
@LyQuocCuong LyQuocCuong moved this from 🏗 In progress to ✅ Done in eShopOnlineApi Jul 23, 2023
@LyQuocCuong LyQuocCuong linked a pull request Jul 23, 2023 that will close this issue
[SOA-028][Enhancement] Log the messages for entire the Business (Service). #52
Merged
@LyQuocCuong
Copy link
Owner Author

=====AFTER=====

1) Describe the solutions

  • Log all the messages in Business Layer (Services).

2) Pros and Cons of this solution

  • No.

3) Are there any NEW (technical, code,...) ?

  • No.

4) Is it challenging and difficult to do? Why?

  • No.

5) Any other notes?

  • No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LyQuocCuong LyQuocCuong

Labels
[Level] Easy Level of Issues [Type] Enhancement Type of Issues
Projects
eShopOnlineApi
Status: ✅ Done
Milestone
[Stage01] Foundation (2 Sprints)
1 participant
@LyQuocCuong