fix(manager): Create reproducible builds on Windows #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vite currently has a bug that causes it to generate different bundles on
Windows and Linux. This is caused by a fault in @rollup/plugin-commonjs
which is bundled into Vite.
We directly fix the fault in our `node_modules/` using patch-package.
Let's hope the Rollup devs accept my PR and the fix is integrated into
Vite.
More links:
- Bug reports:
- vitejs/vite#2623
- rollup/plugins#923
- Related pull requests:
- rollup/plugins#924
pastelmind
added a commit
that referenced
this pull request
Aug 23, 2021
Notes: - Update Vite to 2.5.0, which fixes a bug that caused absolute paths of dependencies to leak into the bundle (and the sourcemap). This was discovered in pull request #62, investigated further in issue #75, and then remedied via monkeypatching Vite in PR #77. Now that Vite has fixed the bug, we can remove the monkeypatch. (`patch-package` is still needed to work with `react-virtualized`)
pastelmind
added a commit
that referenced
this pull request
Aug 23, 2021
Notes: - Update Vite to 2.5.0, which fixes a bug that caused absolute paths of dependencies to leak into the bundle (and the sourcemap). This was discovered in pull request #62, investigated further in issue #75, and then remedied via monkeypatching Vite in PR #77. Now that Vite has fixed the bug, we can remove the monkeypatch. (`patch-package` is still needed to work with `react-virtualized`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR monkey-patches Vite so that it produces identical bundles on Windows and Linux.
Vite currently has a bug that causes it to generate different bundles on Windows and Linux. This is caused by a bug in @rollup/plugin-commonjs where paths with non-OS-specific separators ('/') are not handled correctly.
I'm working on a PR to resolve the root cause. While we wait, let's monkey-patch Vite using patch-package so that we can enjoy reproducible builds today.
Closes #75