You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bundles for Philter Manager (the new one) are different on Windows and Linux. I discovered this while attempting to process #62 -- the bundles built by @midgleyc (on WSL) were different from the ones I built on my machine (Windows). If I build the bundles on Ubuntu 20.04 (WSL 2, Windows 10), the bundles were the same.
After a few days of puzzling and experimentation, I tracked this down to a Vite problem. When I disabled build.minify, Vite would produce differently named variables on Windows and Linux.
Notes:
- Update Vite to 2.5.0, which fixes a bug that caused absolute paths of
dependencies to leak into the bundle (and the sourcemap). This was
discovered in pull request #62, investigated further in issue #75, and
then remedied via monkeypatching Vite in PR #77.
Now that Vite has fixed the bug, we can remove the monkeypatch.
(`patch-package` is still needed to work with `react-virtualized`)
Notes:
- Update Vite to 2.5.0, which fixes a bug that caused absolute paths of
dependencies to leak into the bundle (and the sourcemap). This was
discovered in pull request #62, investigated further in issue #75, and
then remedied via monkeypatching Vite in PR #77.
Now that Vite has fixed the bug, we can remove the monkeypatch.
(`patch-package` is still needed to work with `react-virtualized`)
Bundles for Philter Manager (the new one) are different on Windows and Linux. I discovered this while attempting to process #62 -- the bundles built by @midgleyc (on WSL) were different from the ones I built on my machine (Windows). If I build the bundles on Ubuntu 20.04 (WSL 2, Windows 10), the bundles were the same.
After a few days of puzzling and experimentation, I tracked this down to a Vite problem. When I disabled
build.minify
, Vite would produce differently named variables on Windows and Linux.On Windows:
On Linux:
I suspect this is what causes the (minified) bundles to be different on Windows and Linux as well.
I am pretty sure this is a Vite problem, not a Rollup problem. In fact, Vite has several issues that appear to be related to this:
What can we do?
Edit: This is fixed by #77
Until this is solved, I'll have to move to WSL for generating bundles.[ ] Add info inCONTRIBUTING.md
(We should add this first)[ ] Rebuild bundle in WSLThe text was updated successfully, but these errors were encountered: