Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the desktop icon is incorrect on macos #604

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

LinuxSuRen
Copy link
Owner

We highly recommend you read the contributor's documentation before starting the review process especially since this is your first contribution to this project.

It was updated on 2024/5/27

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@LinuxSuRen LinuxSuRen added bug Something isn't working skip-changelog labels Jan 25, 2025
Copy link

github-actions bot commented Jan 25, 2025

There are 1 test cases, failed count 0:

Name Average Max Min Count Error
10.713488ms 13.683356ms 8.354008ms 3 0

Reported by api-testing.

Copy link

codacy-production bot commented Jan 25, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.22% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4f7f5a0) 18685 7771 41.59%
Head commit (e6d35ec) 18956 (+271) 7925 (+154) 41.81% (+0.22%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#604) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@LinuxSuRen LinuxSuRen merged commit 768b79f into master Jan 26, 2025
19 checks passed
@LinuxSuRen LinuxSuRen deleted the fix/desktop-icon-macos branch January 26, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant