Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Videos now autoplay when opening a post #2826

Closed
4 tasks done
Sh4d opened this issue Nov 28, 2024 · 1 comment · Fixed by #2883
Closed
4 tasks done

Videos now autoplay when opening a post #2826

Sh4d opened this issue Nov 28, 2024 · 1 comment · Fixed by #2883
Labels
bug Something isn't working

Comments

@Sh4d
Copy link

Sh4d commented Nov 28, 2024

Requirements

  • This is a bug report, and if not, please post to https://lemmy.ml/c/lemmy_support instead.
  • Please check to see if this issue already exists.
  • It's a single bug. Do not report multiple bugs in one issue.
  • It's a frontend issue, not a backend issue; Otherwise please create an issue on the backend repo instead.

Summary

This commit that added iframes for embedded video support, also auto-plays the videos on Firefox mobile. This was probably not intentional?

2fdd420#diff-e2d1f9d4db6cbdc86184d404260a6d50f4594bdd99605d3ef1f41f59298d0869R264

Switching to the video tag should resolve this - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/video

More details here - https://lemmy.ca/post/33891198?scrollToComments=true

Steps to Reproduce

  1. Open https://lemm.ee/post/48348392 on firefox mobile
  2. See video play

Technical Details

Firefox android 132.0.2

Lemmy Instance Version

0.19.7

Lemmy Instance URL

https://lemm.ee/post/48348392
@Sh4d Sh4d added the bug Something isn't working label Nov 28, 2024
dessalines added a commit that referenced this issue Jan 5, 2025
@dessalines
Using video tag for embed video urls that are videos.
f1beecc 
- Fixes #2826
@dessalines
Copy link
Member

We can't do anything if the video embed from the metadata they posted isn't a video but an embed, but I just just add a PR that defaults to video if it appears to be one.

If its an embed url, IE like peertube does: https://peertube.tv/videos/embed/ee57738a-d841-433f-a2a4-c1425e68b626

then there's nothing we can do.

@dessalines dessalines mentioned this issue Jan 5, 2025
Merged
SleeplessOne1917 pushed a commit that referenced this issue Jan 7, 2025
@dessalines
Using video tag for embed video urls that are videos. (#2883)
8e545f4 
* Using video tag for embed video urls that are videos.

- Fixes #2826

* Better check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using video tag for embed video urls that are videos. LemmyNet/lemmy-ui
2 participants
@dessalines @Sh4d