Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect retina displays and adjust wmsParams.width and wmsParams.height accordingly #802

Merged
merged 1 commit into from
Jul 15, 2012

Conversation

Mithgol
Copy link
Contributor

@Mithgol Mithgol commented Jul 14, 2012

Porting #586 to TileLayer.WMS.js as requested in #789.

For WMS layers, if I understand correctly, it is enough to double wmsParams.width and wmsParams.height for retina displays, leaving everything else intact.

mourner added a commit that referenced this pull request Jul 15, 2012
Detect retina displays and adjust wmsParams.width and wmsParams.height accordingly
@mourner mourner merged commit ffe7f9d into Leaflet:master Jul 15, 2012
@Mithgol
Copy link
Contributor Author

Mithgol commented Jul 16, 2012

Ok, I've deleted my fork.

@mourner
Copy link
Member

mourner commented Jul 16, 2012

@Mithgol do you delete forks because they're temporary in your workflow when writing pull requests, or because you're not interested in contributing to Leaflet anymore?

@Mithgol
Copy link
Contributor Author

Mithgol commented Jul 17, 2012

They are indeed temporary in my workflow. If a further need of contributing to Leaflet arises, it would be much easier for me to refork the code (that's a single mouse click) than to merge from upstream (which would need, at the very least, git remote add upstream https://github.com/CloudMade/Leaflet.git and then git fetch upstream before I even _start_ merging anything — and I also tend to forget that commands partially and to doubt their details and to go looking though git manuals).

I report the delete of my forks for the public to know that some of the prevoius http:-style hyperlinks (if they were ever created by anyone) are no longer valid, and that GitHub-style hyperlinks are changed (i.e. f9ea2728b74fe67d6a8e0ba6314184368cc5bfc2 now points to CloudMade@f9ea272 instead of my forked repo, which does not exist).

I am currently not interested in further contributing to Leaflet just because I do not have any more _personal itches to scratch_ (a reference to “The Cathedral and the Bazaar”, section 2, rule 1) currently.

Well… except that I could make a pull request one day to remake most of Leaflet's constructors as John Resig's self-calling constructors, but I won't, because we discussed that on Habrahabr once, and you were clearly against that idea.

@mourner
Copy link
Member

mourner commented Jul 17, 2012

@Mithgol regarding self-calling contructors, I revisited the idea of simplifying the API and decided to add factories for every Leaflet class for a similar purpose, see the changelog: https://github.com/CloudMade/Leaflet/blob/master/CHANGELOG.md

@Mithgol
Copy link
Contributor Author

Mithgol commented Jul 17, 2012

That's great news.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants