Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DomUtil function tests #7547

Merged
merged 11 commits into from
Apr 15, 2022
Merged

DomUtil function tests #7547

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7edcd19
Added tests for getStyle, create & remote, and empty elements dom utils.
LGNorris Apr 3, 2021
fb2f77f
Added a few more tests for the DomUtil functions
LGNorris Apr 3, 2021
cba5d83
Test for testProp, setTransform and setPosition utils
LGNorris Apr 3, 2021
e4ca6e2
Added setPosition and getPosition tests
LGNorris Apr 8, 2021
a166f26
Added getSizeparentnode and getscale tests
LGNorris Apr 8, 2021
46eab01
Added tests for textSelection, imageDrag and outline DomUtils.
LGNorris Apr 9, 2021
cfc3bc5
Fix linting errors
LGNorris Apr 9, 2021
e8ef221
Fixed tests for browser compatibility
LGNorris Apr 9, 2021
144a211
Fixed certain browser specific boundingClientRect issues
LGNorris Apr 9, 2021
4d47363
Merge https://github.com/Leaflet/Leaflet into DomUtil-spec-tests
Falke-Design Mar 18, 2022
452885c
update tests
Falke-Design Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed tests for browser compatibility
  • Loading branch information
@LGNorris
LGNorris committed Apr 9, 2021
commit e8ef2213831d9a34e0207291140b9e98fe2735c6
66 changes: 31 additions & 35 deletions spec/suites/dom/DomUtilSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ describe('DomUtil', function () {

describe('#testProp', function () {
Falke-Design marked this conversation as resolved.
Show resolved Hide resolved
it('Check array of style names return first valid style name for element', function () {
expect(L.DomUtil.testProp(['transform'])).to.not.be.ok();
document.documentElement.style.transform = 'rotate(0deg)';
expect(L.DomUtil.testProp(['transform'])).to.be.ok();
var hasProp;
hasProp = L.DomUtil.testProp(['-webkit-transform', '-webkit-transform', '-ms-tranform', '-o-transform']);
expect(hasProp).to.match(/(?:-webkit-transform|-webkit-transform|-ms-tranform|-o-transform)/);
});
});

Expand All @@ -173,19 +173,17 @@ describe('DomUtil', function () {
expect(L.DomUtil.getStyle(el, 'left')).to.be.equal('0px');
expect(L.DomUtil.getStyle(el, 'top')).to.be.equal('0px');

var x = 100;
var y = 100;
var x = 50;
var y = 55;
var position = L.point(x, y);
L.DomUtil.setPosition(el, position);
expect(L.DomUtil.getStyle(el, 'left')).to.be.equal(x + 'px');
expect(L.DomUtil.getStyle(el, 'top')).to.be.equal(y + 'px');
expect(L.DomUtil.getPosition(el)).to.be.eql({x: x, y: y});

var newX = 333;
var newY = 666;
var newPosition = L.point(newX, newY);
L.DomUtil.setPosition(el, newPosition);
expect(L.DomUtil.getStyle(el, 'left')).to.be.equal(newX + 'px');
expect(L.DomUtil.getStyle(el, 'top')).to.be.equal(newY + 'px');
expect(L.DomUtil.getPosition(el)).to.be.eql({x: newX, y: newY});
});

it("Returns position of an element positioned with setPosition.", function () {
Expand All @@ -200,40 +198,40 @@ describe('DomUtil', function () {

describe('#getSizedParentNode', function () {
Falke-Design marked this conversation as resolved.
Show resolved Hide resolved
it('Find nearest parent element where height / width are not null', function () {
var parentEl = document.createElement('div');
var childEl = document.createElement('div');
el.appendChild(parentEl);
parentEl.appendChild(childEl);
expect(L.DomUtil.getSizedParentNode(childEl)).to.not.eql(parentEl);
parentEl.style.width = '150px';
parentEl.style.height = '150px';
expect(L.DomUtil.getSizedParentNode(childEl)).to.eql(parentEl);
var child = document.createElement('div');
var grandChild = document.createElement('div');
el.appendChild(child);
child.appendChild(grandChild);
child.style.width = child.style.height = '500px';
expect(L.DomUtil.getSizedParentNode(grandChild)).to.eql(child);
});
});

describe('#getScale', function () {
Falke-Design marked this conversation as resolved.
Show resolved Hide resolved
it('Returns scale of element as x & y scales respectively', function () {
var childEl = document.createElement('div');
childEl.style.width = '250px';
childEl.style.height = '250px';
childEl.style.padding = '15px';
childEl.style.margin = '25px';
el.appendChild(childEl);
var scale = {
x: 1,
y: 1,
boundingClientRect: {
left: 25,
right: 305,
top: 25,
x: 25,
y: 25,
width: 280,
height: 280,
top: 25,
right: 305,
bottom: 305,
width: 280
left: 25,
}
};
childEl.style.width = '250px';
childEl.style.height = '250px';
childEl.style.padding = '15px';
childEl.style.margin = '25px';
expect(L.DomUtil.getScale(childEl)).to.eql(scale);
expect(JSON.stringify(L.DomUtil.getScale(childEl))).to.eql(JSON.stringify(scale));
childEl.style.padding = '400px';
expect(L.DomUtil.getScale(childEl)).to.not.eql(scale);
expect(JSON.stringify(L.DomUtil.getScale(childEl))).to.not.eql(JSON.stringify(scale));
});
});

Expand Down Expand Up @@ -291,22 +289,20 @@ describe('DomUtil', function () {
var child = document.createElement('div');
el.appendChild(child);
child.tabIndex = 0;
child.style.outline = 'solid';

expect(child.style.outline).to.be.equal('solid');
expect(child.style.outline).to.be.equal(child.style.outline);
L.DomUtil.preventOutline(child);
expect(child.style.outline).to.be.equal('none');
expect(child.style.outline).to.match(/(?:none)/);

// Explicit #restoreOutline through direct call
expect(child.style.outline).to.be.equal('none');
expect(child.style.outline).to.match(/(?:none)/);
L.DomUtil.restoreOutline(child);
expect(child.style.outline).to.be.equal('solid');
expect(child.style.outline).to.be.equal(child.style.outline);

// Implicit #restoreOutline test through simulation
L.DomUtil.preventOutline(child);
expect(child.style.outline).to.be.equal('none');
expect(child.style.outline).to.match(/(?:none)/);
happen.once(child, {type: 'keydown'});
expect(child.style.outline).to.be.equal('solid');
expect(child.style.outline).to.be.equal(child.style.outline);
});
});
});