Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: make Map.openTooltip to consider interactive option #7531

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

johnd0e
Copy link
Collaborator

@johnd0e johnd0e commented Mar 28, 2021

(like Layer.openTooltip)

Fix #5974.


This change is Reviewable

@johnd0e johnd0e force-pushed the fix-5974 branch 2 times, most recently from 41099bd to 99c5303 Compare March 28, 2021 18:32
Copy link
Member

@Falke-Design Falke-Design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Only what we can think of is to rename leaflet-clickable to leaflet-interactive because leaflet-clickable is only used for tooltips. But then also CSS needs to be changed: .leaflet-tooltip.leaflet-clickable{

And I would expect that I can use layer.getTooltip().on('click',(e)=>console.log(e)) but it is not working. But that is a other "bug" and not part of this PR

@johnd0e
Copy link
Collaborator Author

johnd0e commented Oct 31, 2021

Only what we can think of is to rename leaflet-clickable to leaflet-interactive

Good point, to be done in separate PR (after this merged)

@johnd0e
Copy link
Collaborator Author

johnd0e commented Oct 31, 2021

And I would expect that I can use layer.getTooltip().on('click',(e)=>console.log(e)) but it is not working. But that is a other "bug" and not part of this PR

May be because of 'preclick', see #7532

@Falke-Design
Copy link
Member

@mourner your part to approve and merge 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map.openTooltip is not considering options.interactive unlike Layer.openTooltip
3 participants