Prevent default action when opening layers control #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this fix confirmed? It doesn't seem to work on android (DolphinBrowser). |
|
Sorry I don't have an android device to test. It works on the iPad. It uses the same code as L.Control.Zoom (https://github.com/CloudMade/Leaflet/blob/master/src/control/Control.Zoom.js#L21). |
|
@mourner Any reason this is not been merged? |
mourner
added a commit
that referenced
this pull request
Jun 18, 2012
Prevent default action when opening layers control
|
@jacobtoye no reason except lack of time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the layers control for touch browsers the default action for clicking the
<a />is not prevented. This causes a # to be added to the address bar.