Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression after #5661 #5716

Closed
wants to merge 3 commits into from
Closed

Fix regression after #5661 #5716

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24bd077
Fix regression after #5661
Aug 15, 2017
5a41cdc
Update VideoOverlay.js
Aug 15, 2017
acf4d89
Update VideoOverlay.js
Aug 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix regression after #5661
  • Loading branch information
iDm1 authored Aug 15, 2017
commit 24bd077aaf990d45c2110489988a0ce2d63f5e79
4 changes: 2 additions & 2 deletions src/layer/VideoOverlay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ export var VideoOverlay = ImageOverlay.extend({
var wasElementSupplied = this._url.tagName === 'VIDEO';
var vid = this._image = wasElementSupplied ? this._url : DomUtil.create('video');

vid.class = vid.class || '';
vid.class += 'leaflet-image-layer ' + (this._zoomAnimated ? 'leaflet-zoom-animated' : '');
vid.className = vid.className || '';
vid.className += 'leaflet-image-layer ' + (this._zoomAnimated ? 'leaflet-zoom-animated' : '');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we would also need to have a space inserted here, changing the line to:

vid.className += ' leaflet-image-layer ' + (this._zoomAnimated ? 'leaflet-zoom-animated' : '');

Otherwise, if className is specified, it will be concatenated with leaflet-image-layer, a class which most certainly will not exist.


vid.onselectstart = Util.falseFn;
vid.onmousemove = Util.falseFn;
Expand Down