Fix regression after #5661 #5716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perliedman
requested changes
Aug 15, 2017
There was a problem hiding this comment.
Looks good! I added a comment about a gotcha that wasn't introduced here, but best to fix it while we're working with this code anyway.
Looking closer at this - I don't think setting className will work here. vid is a DOM element, and its class should be set by using DomUtil's addClass to ensure full browser compatibility.
src/layer/VideoOverlay.js
Outdated
| vid.class = vid.class || ''; | ||
| vid.class += 'leaflet-image-layer ' + (this._zoomAnimated ? 'leaflet-zoom-animated' : ''); | ||
| vid.className = vid.className || ''; | ||
| vid.className += 'leaflet-image-layer ' + (this._zoomAnimated ? 'leaflet-zoom-animated' : ''); |
There was a problem hiding this comment.
seems we would also need to have a space inserted here, changing the line to:
vid.className += ' leaflet-image-layer ' + (this._zoomAnimated ? 'leaflet-zoom-animated' : '');Otherwise, if className is specified, it will be concatenated with leaflet-image-layer, a class which most certainly will not exist.
added 2 commits
August 15, 2017 14:17
|
Thanks a lot for the PR! Somehow I saw this one after merging #5731 which does exactly the same change, sorry for that :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.