Fix(DomEvent): DomEvent.off should return this #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was broken by 14c5f16.
jelhan
added a commit
to jelhan/ember-leaflet-contextmenu
that referenced
this pull request
Jul 2, 2017
…with 1.0.0 Provided an upstream PR to fix it: Leaflet/Leaflet#5601
jelhan
added a commit
to jelhan/ember-leaflet-contextmenu
that referenced
this pull request
Jul 2, 2017
…with 1.0.0 Provided an upstream PR to fix it: Leaflet/Leaflet#5601
jelhan
added a commit
to jelhan/ember-leaflet-contextmenu
that referenced
this pull request
Jul 2, 2017
…with 1.0.0 Provided an upstream PR to fix it: Leaflet/Leaflet#5601
jelhan
added a commit
to jelhan/ember-leaflet-contextmenu
that referenced
this pull request
Jul 2, 2017
…with 1.0.0 Provided an upstream PR to fix it: Leaflet/Leaflet#5601
perliedman
approved these changes
Jul 3, 2017
|
See #5594 (comment) for a potential gotcha regarding ES6 modules and |
|
https://github.com/yafred/leaflet-responsive-popup is also broken by this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following docs
DomEvent.off()should returnthisbut it was broken in 14c5f16. Leaflet 1.1.0 is affected by this but.