Fire update event from VML renderer #4956
Conversation
|
LGTM |
|
Are you sure rendering still works on IE11, Chrome, Edge? From 1.0.0 to 1.0.1 my canvas rendering code (L.VectorGrid derivate) stopped working. |
|
@t-sch |
|
I didn't say it is a VectorGrid bug but that code that worked on 1.00RC3 and 1.0.0 doesn't work anymore in 1.01. |
|
fiddle/codepen/playground that displays this behaviour, or it didn't happen. |
|
@t-sch vector rendering most definitely works in Chrome; haven't tested personally, but would be very surprised if it didn't work in IE11/Edge and we didn't hear about it. That doesn't mean there aren't edge cases where there has been regressions between release candidates and 1.0.1, so if you believe you've discovered something like that, please open a new issue with details (preferably running code like @IvanSanchez says) regarding the problems you're seeing. |
|
I'm currently trying to locate the reason, a comparison between 1.0.0 and 1.0.1 sources didn't show suspicious code. |
|
@t-sch I think this PR is of interest for you: Leaflet/Leaflet.VectorGrid#15 In short, Leaflet now checks an error parameter, and by accident VectorGrid always passed along a value for that parameter, even when there's no error. |
|
Yesss! |
When refactoring updates, we accidentally created #4950, so vector drawing is currently broken for VML (IE8).
This adds firing the
updateevent from the VML renderer, which is required since it doesn't use it's parents_updatemethod, but ratherL.Renderer's_update, which doesn't fire this event.I have verified that the GeoJSON debug page works again in IE8 after this fix.