Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init interaction regardless of new icon or not #3978

Merged
merged 1 commit into from
Nov 2, 2015
Merged

init interaction regardless of new icon or not #3978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
init interaction regardless of new icon or not 
[issue #3976]

previously interaction only get inited when not reusing icon, i.e. when addIcon
flag is set to true. by taking the statement out of the if condition,
interaction is inited whenever setIcon is called.
  • Loading branch information
Haoyang Xu committed Oct 30, 2015
commit 772220070f0de84dc2adc12c3adb89b607cfa7d3
2 changes: 1 addition & 1 deletion src/layer/marker/Marker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ L.Marker = L.Layer.extend({

if (addIcon) {
this.getPane().appendChild(this._icon);
this._initInteraction();
}
this._initInteraction();
if (newShadow && addShadow) {
this.getPane('shadowPane').appendChild(this._shadow);
}
Expand Down