Skip to content

Some source code not reflected in published versionΒ #8265

Closed
@Kapcash

Description

Checklist

  • I've looked at the documentation to make sure the behavior isn't documented and expected.
  • I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
  • I've searched through the current issues to make sure this hasn't been reported yet.
  • I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce

  1. On current github sources, there is this line of code:

this._resetView(center, zoom, options.pan && options.pan.noMoveStart);

This code's version is coming from PR#6685.

  1. On npm repository, the /src/map/Map.js file doesn't include this code (neither does the built /dist file): https://unpkg.com/leaflet@1.8.0/src/map/Map.js

I also checked on older version like 1.7.1 and 1.6.0.

It looks like this PR#6685 has been merged to the github sources, but is never deployed to production?

Expected behavior

I expect the production version published on npm to included all source code from Github (in the /dist folder as well as /src folder).

Current behavior

The current code published to npm doesn't reflect all the source code present on Github. In particular the code merged by PR#6685

Minimal example reproducing the issue

No response

Environment

  • Leaflet version: 1.8.0
  • Browser (with version): Vivaldi 5.2.2623.48
  • OS/Platform (with version): MacOS BigSur 11.6

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions