Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Cross-Origin Adjustments. #46

Merged
merged 1 commit into from
Feb 19, 2012
Merged

Cross-Origin Adjustments. #46

merged 1 commit into from
Feb 19, 2012

Conversation

DaphneDormanOldAccount
Copy link
Contributor

I made the modifications to compensate for Firefox and added a brief note about CORS. That probably shouldn't reside in the JS file. A more detailed explanation might be appropriate in your readme. I'm happy to write something up if you'd like.

Thanks for all your hard work.

@LeaVerou
Copy link
Owner

Hi there,

Thanks!

Could you please:
a) Move the CORS comment inside the start comment (and explain it's only needed in some cases, it might scare some people as it currently stands)
b) Make the changes in the minified version as well. I usually use Closure Compiler but other minifiers are fine too.

LeaVerou added a commit that referenced this pull request Feb 19, 2012
Cross-Origin Adjustments.
@LeaVerou LeaVerou merged commit 08849d7 into LeaVerou:master Feb 19, 2012
@LeaVerou
Copy link
Owner

Pull request merged. I'll make the above changes myself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants