Skip to content

Commit

Permalink
fix(illuminate): disable snacks.words when illuminate extra is enabled.
Browse files Browse the repository at this point in the history 
Fixes #5125
  • Loading branch information
@folke
folke committed Dec 16, 2024
1 parent 5ea3cfa commit d025115
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions lua/lazyvim/plugins/extras/editor/illuminate.lua
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
-- This works with LSP, Treesitter, and regexp matching to find the other
-- instances.
return {
-- disable snacks words
{ "snacks.nvim", opts = { words = { enabled = false } } },

{
"RRethy/vim-illuminate",
event = "LazyFile",
Expand Down

2 comments on commit d025115

@dpetka2001
Copy link
Contributor

@dpetka2001 dpetka2001 commented on d025115 Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@folke I believe also the following lines

LazyVim/lua/lazyvim/plugins/lsp/init.lua

Lines 49 to 52 in d025115

-- Enable lsp cursor word highlighting
document_highlight = {
enabled = true,
},
should be removed, so that the docs also represent the current state. Otherwise people might read them and think that's the option they have to set instead of doing it with snacks. I had a PR ready for both the lines i mentioned and the illuminate plugin like you did but as I was about to create it, I saw your latest push and opted out of it.

@folke
Copy link
Collaborator Author

@folke folke commented on d025115 Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, done.

Please sign in to comment.