Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

[Bug] Parse command properly in Quick Connect #16

Open
kmahyyg opened this issue Mar 6, 2022 · 17 comments
Open

[Bug] Parse command properly in Quick Connect #16

kmahyyg opened this issue Mar 6, 2022 · 17 comments

Comments

@kmahyyg
Copy link

kmahyyg commented Mar 6, 2022

In quick connect: ssh -p 22 root@192.168.1.1 will not work. Only ssh root@192.168.1.1 -p 22 will work.

Can this command be parsed regardless of -p or other param location?

@kmahyyg
Copy link
Author

kmahyyg commented Mar 6, 2022

Also, id_ed25519.pub is not correctly recognized, which will show invalid public key format in identity tab, but you're still able to proceed.

@kmahyyg
Copy link
Author

kmahyyg commented Mar 6, 2022

Another Bug (or unimplemented feature): When id_rsa is encrypted with another passphrase, it will lead to directly stop the authentication since there's no way to input the passphrase.

@kmahyyg
Copy link
Author

kmahyyg commented Mar 6, 2022

Another Bug: When use CJK IME without switching to English, if you are using Chinese Pinyin, then type whoami, then click enter, it should output whoami to terminal. However, it output whoamiwhoami. Something must go wrong.

@kmahyyg
Copy link
Author

kmahyyg commented Mar 7, 2022

Another Bug: Delete one existing server inside Server tab will result in 5 empty servers to be added.

@kmahyyg
Copy link
Author

kmahyyg commented Mar 7, 2022

Another Bug: Delete Server will not result in ServerCat to exit. There should be some cleanup mechanism.

@Lakr233
Copy link
Owner

Lakr233 commented Mar 7, 2022

Another Bug: Delete one existing server inside Server tab will result in 5 empty servers to be added.

Fixed

@Lakr233
Copy link
Owner

Lakr233 commented Mar 7, 2022

Delete Server will not result in ServerCat to exit. There should be some cleanup mechanism.

Fixed

@Lakr233
Copy link
Owner

Lakr233 commented Mar 7, 2022

Another Bug: When use CJK IME without switching to English, if you are using Chinese Pinyin, then type whoami, then click enter, it should output whoami to terminal. However, it output whoamiwhoami. Something must go wrong.

This should be a bug related to xterm.js, and I'm not able to fix this very soon.

@Lakr233
Copy link
Owner

Lakr233 commented Mar 7, 2022

Another Bug (or unimplemented feature): When id_rsa is encrypted with another passphrase, it will lead to directly stop the authentication since there's no way to input the passphrase.

The password filed is also used to decrypt the private key, I don't get it.

@Lakr233
Copy link
Owner

Lakr233 commented Mar 7, 2022

In quick connect: ssh -p 22 root@192.168.1.1 will not work. Only ssh root@192.168.1.1 -p 22 will work.

Can this command be parsed regardless of -p or other param location?

I did not use the argument parser, the quick connect requires -p at the end of command line so it is a to-do.

@Lakr233
Copy link
Owner

Lakr233 commented Mar 7, 2022

Also, id_ed25519.pub is not correctly recognized, which will show invalid public key format in identity tab, but you're still able to proceed.

Fixed

@kmahyyg
Copy link
Author

kmahyyg commented Mar 7, 2022

Another Bug (or unimplemented feature): When id_rsa is encrypted with another passphrase, it will lead to directly stop the authentication since there's no way to input the passphrase.

The password filed is also used to decrypt the private key, I don't get it.

Well, This problem has two solutions:

  1. Change the caption of dialog from Password to Password / SSH Private Key Passphrase. I cannot reuse my password due to security concern.
  2. Implement a new dialog or new radio button to ask user if this private is encrypted (also, auto-detect would be much perfect).

This is my origin thinking.

$ ssh -vv username@host
debug1: Authentications that can continue: password,publickey,keyboard-interactive
debug1: Next authentication method: password
xxxxxxxxx
debug1: Next authentication method: publickey

Try the password in the dialog first, then use private key offered in the same identity, which simplified user-side configuration of identity.

So that's why I think this is a bug.

@Lakr233
Copy link
Owner

Lakr233 commented Mar 7, 2022

Change the caption of dialog from Password to Password / SSH Private Key Passphrase. I cannot reuse my password due to security concern.

I'll put a notice there next time.

@kmahyyg
Copy link
Author

kmahyyg commented Mar 9, 2022

Thanks for your hard work. I really love this software and appreciate you work.

Another thing that lead to my attention today:

ssh to same machine but with different port (actually port forward to another machine) will lead to terminal title can not be recognized. I personally think the problem might be a race condition.

CleanShot 2022-03-09 at 10 09 21@2x

@kmahyyg
Copy link
Author

kmahyyg commented Mar 9, 2022

Then, there's a bit optimization idea:

the flying-atom animation in the background image of initial tab in each new window will lead to about 40% CPU cost on my M1 MBA. It's really a lot for a SSH terminal. I hope that if a window is minimized to background, this animation should stop rendering.

@Lakr233
Copy link
Owner

Lakr233 commented Mar 9, 2022

the flying-atom animation in the background image of initial tab in each new window will lead to about 40% CPU cost on my M1 MBA. It's really a lot for a SSH terminal. I hope that if a window is minimized to background, this animation should stop rendering.

option will be made to disable this animation in next release
and when this view disappear it should not render any update because the timer will not connect so might be a bug on swiftui side

@kmahyyg
Copy link
Author

kmahyyg commented Mar 9, 2022

Can code snippets be inserted to terminal of connected session?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants