-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SharedFlow collect overload and override that return Nothing #2803
Conversation
I've decided not to add |
Too much of a hassle to do, or from another standpoint like maintaining? I'm asking to know if further PRs from the community to add them for terminal operators have a chance of getting merged. |
Hey, interface Clock: SharedFlow<Int> { ... }
fun Clock() = object: Clock { } the execution fails with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo some doc nits.
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
@LouisCAD to do :) Feel free to create a PR with additional overloads |
Kotlin#2803) * Introduce SharedFlow collect overload and override that return Nothing * Override will ensure the proper implementation of the interface * collect extension is added as the very basic lint helper Fixes Kotlin#2789 Fixes Kotlin#2502 Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Kotlin#2803) * Introduce SharedFlow collect overload and override that return Nothing * Override will ensure the proper implementation of the interface * collect extension is added as the very basic lint helper Fixes Kotlin#2789 Fixes Kotlin#2502 Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Fixes #2789
Fixes #2502