feat(cli): all general commands are implemented #1932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # mm2src/adex_cli/src/adex_app.rs # mm2src/adex_cli/src/adex_proc/adex_proc_impl.rs # mm2src/adex_cli/src/adex_proc/command.rs # mm2src/adex_cli/src/adex_proc/response_handler.rs # mm2src/adex_cli/src/adex_proc/response_handler/orderbook.rs
shamardy
reviewed
Dec 8, 2023
There was a problem hiding this comment.
Thanks you for the fixes @borngraced! Have some minor comments/questions.
Signed-off-by: borngraced <samuelonoja970@gmail.com>
shamardy
reviewed
Dec 12, 2023
Signed-off-by: borngraced <samuelonoja970@gmail.com>
Signed-off-by: borngraced <samuelonoja970@gmail.com>
shamardy
reviewed
Dec 14, 2023
There was a problem hiding this comment.
Thank you for the fixes! Only one minor comment!
I think we should update the deps table here #1932 (comment), remove from the table any row with a dep that is the same as mm2 and only add the ones that are different or new to the table.
Signed-off-by: borngraced <samuelonoja970@gmail.com>
|
@smk762 can you please check if your comments here #1932 (comment) are resolved? |
# Conflicts: # mm2src/coins/eth.rs # mm2src/coins/lightning.rs # mm2src/coins/lp_coins.rs # mm2src/coins/qrc20.rs # mm2src/coins/solana.rs # mm2src/coins/solana/spl.rs # mm2src/coins/tendermint/tendermint_coin.rs # mm2src/coins/tendermint/tendermint_token.rs # mm2src/coins/utxo.rs # mm2src/coins/utxo/bch.rs # mm2src/coins/utxo/slp.rs # mm2src/coins/utxo/utxo_common.rs # mm2src/coins/z_coin.rs
Signed-off-by: borngraced <samuelonoja970@gmail.com>
Signed-off-by: borngraced <samuelonoja970@gmail.com>
ca333
previously approved these changes
Feb 13, 2024
smk762
previously approved these changes
Feb 15, 2024
There was a problem hiding this comment.
All requests in #1932 (comment) have been resolved, thanks!
# Conflicts: # mm2src/komodefi_cli/Cargo.lock # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs
borngraced
force-pushed
the
1799-swap-commands
branch
from
958e7d5 to
3a21e71
Compare
|
Has been deprecated here #2234 , we will provide a more maintainable version for the cli in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the most of commands provided by both Legacy and 2.0 versions of Komodo DeFi framework RPC API that were not introduced in the earlier versions:
swap: active_swaps, my_swap_status, my_recent_swaps, min_trading_vol, max_taker_vol,
network: get_gossip_mesh, get_gossip_peer_topics, get_gossip_topic_peers, get_my_peer_id, get_peers_info, get_relay_mesh
coin: disable_coin, set_required_confirmations, set_requires_notarization, coins_needed_for_kick_start
utility: get_current_mtp, ban_pubkey, list_banned_pubkeys, unban_pubkeys
wallet: show_priv_key, validate_address, kmd_rewards_info
convertaddress, convert_utxo_address, tx_history, sign_message, verify_message, send_raw_transaction, withdraw (v2), get_raw_transaction, get_public_key, get_public_key_hash,
enable: enable_bch_with_tokens, - enable_slp, enable_tendermint_with_assets, enable_tendermint_token, enable_eth_with_tokens, enable_erc20, task_enable_z_coin_init, task_enable_z_coin_status, task_enable_z_coin_cancel
version stat: add_node_to_version_stat, remove_node_from_version_stat, start_version_stat_collection, stop_version_stat_collection, update_version_stat_collection
Dependency Updates:
komodefi-cli