Skip to content

SDK: Overall review comments  #118

Open
@lakshmih

Description

We tried running the SDK as is and have some comments/ feedback on specific samples. Creating an issue so we can discuss this.

cllayerinfo - No Output from the sample

nbodycpp - Passes but animation does not close
conwaycpp - Passes but animation does not close

saxpy - Fails with:
Verification failed! -9127.552734 != -9127.553711 at index 1
Error: CL_INVALID_VALUE

saxpycpp - Fails with:
Error: Verification FAILED!

For the first two tests, we should perhaps improve the sample to provide meaningful output and to exit cleanly. In general, interested in checking if these samples behave the same on other implementations as well.

Rest of the samples look okay on initial review / run.

General comment that it would be useful for samples to log something to stdout if everything ran successfully,.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions