refactor: rename static children (QwikDev#255)

Kesmek · Mar 10, 2022 · 8028547 · 8028547
1 parent 3852547
commit 8028547
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/src/core/api.md b/src/core/api.md
@@ -273,15 +273,15 @@ export type RenderableProps<P, RefType = any> = P & Readonly<{
 // @public (undocumented)
 export const setPlatform: (doc: Document, plt: CorePlatform) => CorePlatform;
 
+// @public (undocumented)
+export const SkipRerender: FunctionComponent<{}>;
+
 // @public (undocumented)
 export const Slot: FunctionComponent<{
     name?: string;
     children?: any;
 }>;
 
-// @public (undocumented)
-export const StaticChildren: FunctionComponent<{}>;
-
 // @public (undocumented)
 export function useDocument(): Document;
 

diff --git a/src/core/index.ts b/src/core/index.ts
@@ -66,7 +66,7 @@ export type { PromiseValue } from './render/jsx/async.public';
 // JSX Runtime
 //////////////////////////////////////////////////////////////////////////////////////////
 export { h } from './render/jsx/factory';
-export { Host, StaticChildren } from './render/jsx/host.public';
+export { Host, SkipRerender } from './render/jsx/host.public';
 export { Slot } from './render/jsx/slot.public';
 export { Fragment, jsx, jsxDEV, jsxs } from './render/jsx/jsx-runtime';
 export type {

diff --git a/src/core/render/cursor.ts b/src/core/render/cursor.ts
@@ -10,7 +10,7 @@ import { assertDefined, assertEqual } from '../assert/assert';
 import { NodeType } from '../util/types';
 import { intToStr } from '../object/store';
 import { EMPTY_ARRAY } from '../util/flyweight';
-import { StaticChildren } from './jsx/host.public';
+import { SkipRerender } from './jsx/host.public';
 import { logDebug, logError } from '../util/log';
 
 type KeyToIndexMap = { [key: string]: number };
@@ -59,7 +59,7 @@ export function smartUpdateChildren(
   mode: ChildrenMode,
   isSvg: boolean
 ) {
-  if (ch.length === 1 && ch[0].type === StaticChildren) {
+  if (ch.length === 1 && ch[0].type === SkipRerender) {
     if (elm.firstChild !== null) {
       return;
     }
@@ -239,7 +239,7 @@ export function patchVnode(
     return;
   }
 
-  if (tag === Host || tag === StaticChildren) {
+  if (tag === Host || tag === SkipRerender) {
     return;
   }
 
@@ -472,7 +472,7 @@ function createElm(ctx: RenderContext, vnode: JSXNode, isSvg: boolean): ValueOrP
   return then(wait, () => {
     let children = vnode.children;
     if (children.length > 0) {
-      if (children.length === 1 && children[0].type === StaticChildren) {
+      if (children.length === 1 && children[0].type === SkipRerender) {
         children = children[0].children;
       }
       const slotMap = isComponent ? getSlots(componentCtx, elm) : undefined;

diff --git a/src/core/render/jsx/host.public.ts b/src/core/render/jsx/host.public.ts
@@ -28,4 +28,4 @@ export const Host: FunctionComponent<Record<string, any>> = { __brand__: 'host'
 /**
  * @public
  */
-export const StaticChildren: FunctionComponent<{}> = { __brand__: 'skip' } as any;
+export const SkipRerender: FunctionComponent<{}> = { __brand__: 'skip' } as any;
diff --git a/src/core/render/jsx/jsx-runtime.ts b/src/core/render/jsx/jsx-runtime.ts
@@ -1,7 +1,7 @@
 import type { FunctionComponent, JSXNode } from './types/jsx-node';
 import type { QwikJSX } from './types/jsx-qwik';
 import { qDev } from '../../util/qdev';
-import { Host, StaticChildren } from './host.public';
+import { Host, SkipRerender } from './host.public';
 import { EMPTY_ARRAY } from '../../util/flyweight';
 import { logWarn } from '../../util/log';
 
@@ -47,7 +47,7 @@ export function processNode(node: any): JSXNode[] | JSXNode | undefined {
     return undefined;
   }
   if (isJSXNode(node)) {
-    if (node.type === Host || node.type === StaticChildren) {
+    if (node.type === Host || node.type === SkipRerender) {
       return node;
     } else if (typeof node.type === 'function') {
       return processNode(node.type({ ...node.props, children: node.children }, node.key));